WIP: Multiple y-axis formatting #6320
Conversation
| anchorAxis = { | ||
| _offset: ax._anchorAxis._offset - xshift, | ||
| _length: ax._anchorAxis._length | ||
| }; |
There was a problem hiding this comment.
ax._anchorAxis contains several other keys and values that may be of interest for other functions.
Wondering it might be better to use Lib.extendFlat e.g.
anchorAxis = extendFlat({}, ax._anchorAxis, {
_offset: ax._anchorAxis._offset - xshift,
_length: ax._anchorAxis._length
});or alternatively mutate ax._anchorAxis directly i.e.
ax._anchorAxis._offset = ax._anchorAxis._offset - xshift;
ax._anchorAxis._length = ax._anchorAxis._length;?
There was a problem hiding this comment.
I ran into difficulties with the latter in that this function is called multiple times during the axis drawing so the offset value ends up as double what it should be.
Could you clarify the issue with the modification here? I'm not totally understanding as this seems to be following the same pattern as was already implemented eg. in lines 3809-3817 below.
src/plots/cartesian/axes.js
Outdated
| @@ -2345,12 +2344,20 @@ axes.drawOne = function(gd, ax, opts, allDepths) { | |||
| // to determine how much to shift this one out by | |||
| // TODO: Also need to account for the expected depth of the current axis | |||
| // (if drawing from the left inwards) | |||
| if(axLetter === 'y') { | |||
| if(axLetter === 'y' & !ax.position > 0) { | |||
There was a problem hiding this comment.
I am not sure if understand the statement here.
!ax.position would be true or false and we are comparing it to be greater than zero?
Let's rewrite this statement.
|
Closing this in favour of #6334 |
A simpler starting implementation of #6319, where we assume a constant offset (
xshift) applied to anchored y axes that may be set to either the left or right side of a plot.To-do's:
automargin=Trueto be set for the first y-axes. This is causing multiple redraws of the axes, but without it theGetLinePosition()function gets called before the axis is drawn and so there isn't anyxshiftto be applied.Error: <text> attribute x: Expected length, "NaN"errors (although I can't find any impact of this on the output plot.