Skip to content

Can't load assets with URL that contains the file name #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
catarak opened this issue Oct 31, 2019 · 3 comments · Fixed by #1475
Closed

Can't load assets with URL that contains the file name #1205

catarak opened this issue Oct 31, 2019 · 3 comments · Fixed by #1475

Comments

@catarak
Copy link
Member

catarak commented Oct 31, 2019

Nature of issue?

  • Found a bug

Details about the bug:

  • Web browser and version: Chrome
  • Operating System: Mac OSX
  • Steps to reproduce this bug:

I noticed that example P_1_2_2_01 doesn't work in the web editor. It's not able to load the images, and makes a request to the following url: https://cdn.jsdelivr.net/gh/generative-design/Code-Package-p5.js@master/01_P/P_1_2_2_01/https://cdn.jsdelivr.net/gh/generative-design/Code-Package-p5.js@master/01_P/P_1_2_2_01/data/pic1.jpg. The example works if you change the names of the images, check out my forked version that works.

The reason for this strange issue is that the file URL contains within it the file name as specified in the web editor. When the HTML is being created, the file name is replaced with its url, which happens twice to account for all edge cases.

@ashu8912
Copy link
Contributor

Working on it

@ashu8912
Copy link
Contributor

@catarak couldn't figure out how this URL generation is occurring can you guide me a little here.

@ashu8912
Copy link
Contributor

ashu8912 commented Feb 1, 2020

@catarak any updates on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants