Skip to content

Fix File Link Resolution #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Conversation

dhoizner
Copy link

@dhoizner dhoizner commented Jun 25, 2020

Fixes #1205, Fixes #1217, Fixes #1463

This pull changes the string replace to operate on the full quoted path passed to the loadThingies functions, which mitigates the issues that arise from having multiple files with the same name at different levels of the sketch hierarchy or a filename that is contained in the url of a different file.

Also updates installation.md to be more accurate with regards to S3_BUCKET_URL_BASE.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak
Copy link
Member

catarak commented Jun 29, 2020

Thank you! I tested with the sketches linked in #1205 and #1463 and it is working great.

In the future, it would be helpful if you separated the changes into different PRs, since they are unrelated.

@catarak catarak merged commit 912a2bf into processing:develop Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants