Skip to content

Fixes #1217, adds support same file names in different folders #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixes #1217, adds support same file names in different folders #1279

wants to merge 1 commit into from

Conversation

akshay-99
Copy link
Member

@akshay-99 akshay-99 commented Feb 23, 2020 •
edited
Loading

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

Fixes #1217
Also Fixes #1205

@akshay-99
Fixes processing#1217, adds support same file names in different folders
fd094f6 
Fix the regex check so as to perform the
replace when the path matches exactly.
For e.g. A pass looking for 'data.json' won't
affect 'assets/data.json' or '/data.json'.
They will be handled separately in their own passes.
@welcome
Copy link

welcome bot commented Feb 23, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@akshay-99 akshay-99 requested a review from catarak February 23, 2020 15:50
@catarak catarak closed this Mar 24, 2020
@catarak
Copy link
Member

catarak commented Mar 24, 2020

I don't think this is a good solution—rather than addressing the underlying issue causing this bug, I think this fixes it in a hacky way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catarak catarak Awaiting requested review from catarak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

same name files in different folders doesn't work Can't load assets with URL that contains the file name
2 participants
@akshay-99 @catarak