-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Missing ARIA label NavBasic, Removing Italian entry from Language Dropdown, Changing translation for Asset #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding ARIA Label in NavTest Changing translation from Asset to Recurso for spanish
# Conflicts: # client/components/Nav.jsx
@andrewn Can you have a look at this, please? Conflicts have been solved and it's up to date. |
@oruburos When I load my user's assets page (http://localhost:8000/andrewn/assets), I see a blank screen. The Web Inspector's console tab shows the following error:
Can you take a look please? |
i'm really excited to get this in! do y'all think this is the last PR before i can turn the spanish translation on in production? |
@andrewn Can you have a look at this, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
@catarak My feeling is that we can turn this on and address the two other issues soon. |
Makes sense to me! I think it's okay to have the translation mostly done and to start getting feedback from users. |
Addresses some points in discussion #1509
I have verified that this pull request:
npm run lint
)This PR addresses :