Skip to content

Move IDEOverlays into a separate component #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

lindapaiste
Copy link
Collaborator

Progress on #1458

Merge after #2335

Changes:

  • Move the section of the code for rendering modals and overlays out of IDEView and into a new component IDEOverlays, as discussed in Refactor IDEView #1458

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste requested a review from raclim August 7, 2023 21:38
@dewanshDT dewanshDT mentioned this pull request Aug 17, 2023
3 tasks
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this!

As we discussed earlier, updating the snapshots here might not have been the best solution, but I felt that we could create a separate issue about it if needed!

@raclim raclim merged commit 7c3ea21 into processing:develop Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants