-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Useable Mobile Editor 🎉 #2387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Useable Mobile Editor 🎉 #2387
Conversation
…s-web-editor into dewanshmobile/ide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some first thoughts. Will continue reviewing later.
|
||
> header { | ||
display: flex; | ||
${prop('MobilePanel.secondary')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we’ve got a value with no property? Here and on line 21.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no this is to set the background color, it automatically does that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can also change all the foreground
key in the theme to color
to set the color and background automaticall by just writing this one line ${prop('some object background and color property')}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I see what you’re saying. You put the “color:” part in the theme object. So it’s like a mixin rather than a color variable.
We discussed how a lot of the prevProps comparisons could be avoided if you handled each useEffect separately with the dependency on the prop you are trying to detect changes in. |
yeah I remember that, will work on all the changes now |
hey @lindapaiste, Just made all the changes and push the code check it out! |
…s-web-editor into dewanshmobile/ide
Co-authored-by: Linda Paiste <[email protected]>
…s-web-editor into dewanshmobile/ide
* cleanup unused vars * add dependencies to `useEffect`s
cleanup IDEView
Fixes #issue-number
Changes:
The useable editor is now available in mobile!!

before merging this, following PRs need to be merged
#2052
#2347
#2362
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.