Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useable Mobile Editor 🎉 #2387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Useable Mobile Editor 🎉 #2387
Changes from 42 commits
953b772
be50580
bc3b2c5
ae19086
9181989
a847e3f
00724fd
822f247
c12f2d7
ad3fbbb
178c37c
1aff6da
0a2c755
c7b26d7
f274edd
3a25305
6f2f428
9f97e4e
c83c1cc
47db20a
5c3b40b
f0521ce
828e182
c1f41a4
29db062
7e03969
e70da37
0f9e496
5861053
52054dc
c508ee6
e51df1e
f33574e
7b26a79
67043d9
8d36f7e
f0490b8
2428625
7b309ed
2a2fa99
8745281
a3ad31a
62daa3c
640a293
3fed465
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we’ve got a value with no property? Here and on line 21.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no this is to set the background color, it automatically does that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can also change all the
foreground
key in the theme tocolor
to set the color and background automaticall by just writing this one line${prop('some object background and color property')}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I see what you’re saying. You put the “color:” part in the theme object. So it’s like a mixin rather than a color variable.