Skip to content

fixed about modal when window size is resized #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanjay-sol
Copy link

Fixes #2565
Ref #2531

Changes:
I have addressed and resolved issue #2565, which involved ensuring that the "Report a bug" and "Code of Conduct" sections no longer exceed the boundaries of the "About" modal when the window size is resized .

The behavior of the about component has been successfully resolved. Prior to the changes, it appeared as follows:

bug

Following the alterations, it now appears in an improved state:

Screenshot 2023-11-04 at 3 43 36 PM

As there haven't been any merged pull requests for issue #2531, I've redesign it to the best of my abilities. I request feedback from @raclim and @lindapaiste regarding whether it's appropriate to retain these changes exclusively for issue #2565. If it's preferable to keep the modifications isolated to this specific issue, I'll be happy to re-submit the pull request with the code affecting issue #2531 removed.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@sanjay-sol sanjay-sol force-pushed the sanjay-sol/fixed-exceeding-above-modal branch from 6ae1722 to 879c1dd Compare November 17, 2023 15:49
@raclim
Copy link
Collaborator

raclim commented Jan 26, 2024

Thanks for submitting this!

I think after receiving several issues regarding the About Modal we might want to go with redesigning it for a longer term solution over implementing smaller fixes, so I'm going to close this for now. I'm sorry we weren't able to get this in, but please feel free to join in the megathread discussing the About Modal's design or check out other issues in this repository!

@raclim raclim closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report a bug and code of conduct exceeds from about modal when window size is resized
2 participants