Skip to content

Issue #2531 - Fixed bug and responsiveness of About modal #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

harsh-kh08
Copy link

Fixes #2531

Changes:

  • Fixed the bug as mentioned
  • Improved the responsiveness of About Page Component

Mobile View

Mobile View

Desktop View

Desktop View

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #2531

@raclim
Copy link
Collaborator

raclim commented Jan 26, 2024

Thanks for submitting this!

I think after receiving several issues regarding the About Modal we might want to go with redesigning it for a longer term solution over implementing smaller fixes, so I'm going to close this for now. I'm sorry we weren't able to get this in, but please feel free to join in the megathread discussing the About Modal's design or check out other issues in this repository!

@raclim raclim closed this Jan 26, 2024
@harsh-kh08
Copy link
Author

Thanks for submitting this!

I think after receiving several issues regarding the About Modal we might want to go with redesigning it for a longer term solution over implementing smaller fixes, so I'm going to close this for now. I'm sorry we weren't able to get this in, but please feel free to join in the megathread discussing the About Modal's design or check out other issues in this repository!

Thanks Raclim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In About modal position of "Contribute" and "Report a bug" is not consistent
3 participants