-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Feat: Give Preferred language based Credential Error from Backend #2898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Removed the console.log
This shows a lot of potential! Translating server-side messages is something that we've been discussing for a long time. See #1587 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What to do next? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Thanks so much for your work on this! Due to some of the changes here falling out of date and some of the other features/fixes we'd like to prioritize over the next two months, I'm going to close this pull request for now. I'm really sorry that it took a while to get to this and that we couldn't get this in at the moment, but please feel free to update and reopen this pull request in the future! |
Fixes #2860
Changes:
Nav.jsx
component, a backend request is sent to the endpoint/getCurrentLanguage
to store the current language. The language is then changed usingi18n.changeLanguage(language);
.i18nextMiddleware
to capture the language and facilitate mapping errors accordingly.I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #2860