Error message for invalid token while email verification isn't clear

[aryanas159]

p5.js version

1.9.0

What is your operating system?

Windows

Web browser and version

No response

Actual Behavior

If the token is invalid the error message is something went wrong.

Expected Behavior

The error message should be more clear and state that the token is invalid or expired.

Steps to reproduce

This behavior will probably not be visible on the main p5 js website, considering it's an enhancement from my previous pull request which has been merged so it should be visible on the develop branch.

[aryanas159]

@lindapaiste How would you like to proceed with this?

Currently, we are displaying the message EmailVerificationView.InvalidState in case the token is invalid.

We could either change this message for every translation file to something more appropriate like you suggested Token is invalid or expired.

Or we could instead display the EmailVerificationView.InvalidTokenNull message for the invalid token as well.

[lindapaiste]

Or we could instead display the EmailVerificationView.InvalidTokenNull message for the invalid token as well.

Hmm the name "InvalidTokenNull" does suggest that it was intended to be used for both null and invalid tokens, doesn't it? I'm going to see if I can dig up the issues and PR from back when this was first implemented to see what was discussed then.

[lindapaiste]

I checked the history and we have always displayed the "something went wrong" message. This is potentially related to #1587, because we get back a more descriptive message from the server but it's not translated. PR #2898 opens up the ability to translate the message from the backend. We could also change the translation on the frontend.

[aryanas159]

@lindapaiste I think for this case, using the frontend translations is better, should we display the EmailVerificationView.InvalidTokenNull message, since we already have translations for it.

[poswalsameer]

@lindapaiste I think for this case, using the frontend translations is better, should we display the EmailVerificationView.InvalidTokenNull message, since we already have translations for it.

Hi, is this issue still active? I would surely like to work on this one if this is still an open one.

[Harshit-7373]

@raclim Please Review my PR & merge the PR to close the Issue.

[Harshit-7373]

@raclim @aryanas159 In my Pull Request , The languages for which I have updated the translations.json files are: Hindi, English (US), Korean, French, and Portuguese.

Please Review it.

[Harshit-7373]

@raclim There was one of my pull requests that you reviewed, but I didn’t receive any response on it. Could you let me know if there are any errors or if any modifications are required?

The issue number is Where my PR was submitted was : - #3163
The Pull Requests number was :- #3336