Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for Invalid Email Verification Token #3347

Merged

Conversation

Harshit-7373
Copy link
Contributor

@Harshit-7373 Harshit-7373 commented Feb 20, 2025

Solved Error message for invalid token while email verification isn't clear #2861 .

github - Harshit-7373

Fixes #2861

  1. I changed the Invalid State section for each translations.json file to 'Token is invalid or expired' based on the translations stated there.
  2. The languages for which I have updated the translations.json files are: Hindi, English (US), Korean, French, and Portuguese.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Solved Error message for invalid token while email verification isn't clear processing#2861 .

github - Harshit-7373
@raclim raclim changed the title Solved issue #2861 Translations for Invalid Email Verification Token Feb 20, 2025
@raclim
Copy link
Collaborator

raclim commented Feb 20, 2025

Thanks for submitting this!

I'm seeing that there's a lot of languages here on this pull request. Ideally we try not to rely solely on machine translations, and have incoming translations vetted by native speakers before merging them in. I think there's two options on where this PR could go:

  • We can keep this PR open and add a "Help Wanted" tag to try to get more native speaker's eyes on this. If we go this route, we should update the description for this PR with a list of the languages that this includes, and potentially think of how to get more eyes on this. This process would definitely take a while!

  • Another option is to adjust this PR to only translate the languages that you may speak. We can still create a list of missing translations and add it to the original issue to inform incoming contributors. This approach also lets us merge in the new translations in chunks rather than all at once.

I personally feel that it might be better to go with the second option, but let me know which sounds better to you or if you have any other suggestions, thanks!

@Harshit-7373
Copy link
Contributor Author

@raclim Even I feel that the second option is the right approach. I will make the necessary changes to my pull request, keeping only the languages I know and can confidently verify as correct while removing the rest.

After making these changes, I will update the PR description to specify the languages I modified. Once I am certain about the accuracy of the other translations, I will create a new pull request for them separately.

@Harshit-7373
Copy link
Contributor Author

@raclim I have made the necessary changes, and my PR now includes all the languages I know and can confidently verify as correct. Please review and merge it to close the issue. Soon, I will try to understand the remaining languages and submit a new PR for them.

@Harshit-7373
Copy link
Contributor Author

@raclim I have updated the description of the PR and also reflected the same in the comment section of the issue.

@raclim
Copy link
Collaborator

raclim commented Feb 21, 2025

Cool, thanks for making these updates! I think the only remaining task here is that I think you might've ended up deleting the other translation files rather than removing the changes you made to them. Would you be able to restore these files to their original state?

Thanks and let me know if you have any questions about this process!

@Harshit-7373
Copy link
Contributor Author

Harshit-7373 commented Feb 22, 2025

@raclim I have successfully restored the deleted files and made the necessary changes. Please let me know if any further modifications are required.

I believe everything is correct now. Please review it and merge the PR.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks so much for the update!

I removed a few extra spaces, but this feels good to me! I think one last step that might need to be done is to open a new issue regarding the remaining translations for the message—please feel free to go ahead with opening that issue if you'd like!

@Harshit-7373
Copy link
Contributor Author

@raclim Just give me a minute. I will open the issue.

Also, I have one question: After opening the issue, will I be allowed to open a PR and post a solution related to it?

@raclim
Copy link
Collaborator

raclim commented Feb 22, 2025

Yes, you will be able to open a PR for it! Since it has languages that would probably need to be verified by other contributors who speak those languages, it might take a while though to see it to completion. I think it might be great to list any thoughts or suggestions you might have for what type of plan or structure we could set up to confirm these translations to the issue as well!

Let me know if you have any further questions and thanks so much again for your work on this!

@raclim raclim merged commit b5dd69d into processing:develop Feb 22, 2025
1 check passed
@Harshit-7373
Copy link
Contributor Author

@raclim I agree! New contributors or native speakers can help verify the changes. Additionally, using Google Translate after human review can ensure 100% accuracy. This way, the community collaborates effectively and grows together.

@Harshit-7373
Copy link
Contributor Author

@raclim Also, I opened an issue for the remaining languages that have incorrect translations. The issue number is #3349.
Please check it once. Thank you for reviewing this Pull Request and merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message for invalid token while email verification isn't clear
2 participants