-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations for Invalid Email Verification Token #3347
Translations for Invalid Email Verification Token #3347
Conversation
Solved Error message for invalid token while email verification isn't clear processing#2861 . github - Harshit-7373
Thanks for submitting this! I'm seeing that there's a lot of languages here on this pull request. Ideally we try not to rely solely on machine translations, and have incoming translations vetted by native speakers before merging them in. I think there's two options on where this PR could go:
I personally feel that it might be better to go with the second option, but let me know which sounds better to you or if you have any other suggestions, thanks! |
@raclim Even I feel that the second option is the right approach. I will make the necessary changes to my pull request, keeping only the languages I know and can confidently verify as correct while removing the rest. After making these changes, I will update the PR description to specify the languages I modified. Once I am certain about the accuracy of the other translations, I will create a new pull request for them separately. |
@raclim I have made the necessary changes, and my PR now includes all the languages I know and can confidently verify as correct. Please review and merge it to close the issue. Soon, I will try to understand the remaining languages and submit a new PR for them. |
@raclim I have updated the description of the PR and also reflected the same in the comment section of the issue. |
Cool, thanks for making these updates! I think the only remaining task here is that I think you might've ended up deleting the other translation files rather than removing the changes you made to them. Would you be able to restore these files to their original state? Thanks and let me know if you have any questions about this process! |
@raclim I have successfully restored the deleted files and made the necessary changes. Please let me know if any further modifications are required. I believe everything is correct now. Please review it and merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks so much for the update!
I removed a few extra spaces, but this feels good to me! I think one last step that might need to be done is to open a new issue regarding the remaining translations for the message—please feel free to go ahead with opening that issue if you'd like!
@raclim Just give me a minute. I will open the issue. Also, I have one question: After opening the issue, will I be allowed to open a PR and post a solution related to it? |
Yes, you will be able to open a PR for it! Since it has languages that would probably need to be verified by other contributors who speak those languages, it might take a while though to see it to completion. I think it might be great to list any thoughts or suggestions you might have for what type of plan or structure we could set up to confirm these translations to the issue as well! Let me know if you have any further questions and thanks so much again for your work on this! |
@raclim I agree! New contributors or native speakers can help verify the changes. Additionally, using Google Translate after human review can ensure 100% accuracy. This way, the community collaborates effectively and grows together. |
Solved Error message for invalid token while email verification isn't clear #2861 .
github - Harshit-7373
Fixes #2861
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123