Factor transformations into position and area for shapes' accessible outputs - addresses #4721 #6122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses suggestion raised in #4721
Specifically this comment
Changes:
Currently, transformations are not taken into account for outputs generated through textOutput() or gridOutput(). This PR modifies _getPos and _getArea to be methods on the p5 prototype and to factor in the current transformations into their calculations.
You can see that in this example. Three squares are on the canvas in different positions with the square in the lower right being scaled down, but the text output describes only one shape because the arguments passed into square() are the same and because the color is the same.
Here's that same example with the build from this PR.
PR Checklist
npm run lint
passes