Upgrade from AppWrapper v1beta1 to v1beta2 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
3 tasks
4 tasks
dgrove-oss
force-pushed
the
mcadv1b2
branch
2 times, most recently
from
42d0fcb to
5fce708
Compare
|
This PR is now ready for review. |
|
/lgtm |
1. Replace MCAD dependency with AppWrapper 2. Upgrade AppWrapper from v1beta1 to v1beta2 3. Upgrade to go 1.21 4. Upgrade go dependencies to match Kueue/AppWrapper requirements 5. Fix bug in fakeclient initialization (dynamic interface not initialized)
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrove-oss, KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
What changes have been made
Context: This PR supports the migration of the codeflare operator from MCADv1 to Kueue+AppWrapper. We should probably wait on merging this PR until the corresponding PRs on the consuming codeflare repos are ready, as the removal of MCADv1 CRDs is a breaking change.
Change summary
Verification steps
I manually ran
go test ./support/. -vChecks