Upgrade from AppWrapper v1beta1 to v1beta2 #484
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dgrove-oss
force-pushed
the
mcadv1b2
branch
6 times, most recently
from
b0c8895 to
a34e6f4
Compare
|
This PR is now ready for review. |
| @@ -64,11 +64,12 @@ jobs: | |||
| with: | |||
| repository: project-codeflare/codeflare-operator | |||
| path: codeflare-operator | |||
| ref: mcadv1b2 | |||
There was a problem hiding this comment.
Will this stay mcadv1b2 or is this only because the CFO PR isn't merged yet?
There was a problem hiding this comment.
This is only because the CFO PR isn't merged. Once we merge all the pieces, this goes back to pulling from main.
openshift-merge-robot
added
the
needs-rebase
1. Update all AppWrapper related code 2. Remove InstaScale related code, examples, tests. 3. No customized priorities in v1beta2; remove code/tests.
openshift-merge-robot
removed
the
needs-rebase
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Closing as outdated. |
Issue link
What changes have been made
Context: This PR supports the migration of the codeflare operator from MCADv1 to Kueue+AppWrapper. We should probably wait on merging this PR until the corresponding PRs on the consuming codeflare repos are ready, as the removal of MCADv1 CRDs is a breaking change.
Depends on: project-codeflare/codeflare-common#37
Verification steps
I have verified that unit tests are running locally.
I expect end-to-end tests will fail because there is a circular dependency between updates to the SDK and updates to the codeflare operator (the e2e tests for this repo install the codeflare operator, which can't be updated until the SDK is updated).
Checks