Skip to content

Cleanup of codeflare-common defaults and Makefile #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

sutaakar
Copy link
Contributor

Removing CodeFlare SDK version as CodeFlare SDK doesn't use Go lang tests any more.
Adjusted Makefile to align with current content of defaults.go

Issue link

N/A

What changes have been made

Cleanup of default values and Makefile.

Verification steps

N/A, there should be no functionality change.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Removing CodeFlare SDK version as CodeFlare SDK doesn't use Go lang tests any more.
Adjusted Makefile to align with current content of defaults.go
Copy link
Collaborator

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, wanted to do that for a long time :)

Copy link

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [astefanutti,sutaakar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 758dad4 into project-codeflare:main Sep 27, 2024
3 checks passed
@sutaakar sutaakar deleted the cleanup branch September 27, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants