-
Notifications
You must be signed in to change notification settings - Fork 64
Generate MCAD clients #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@astefanutti I have followed the example set in this PR to generate the clients. Unfortunately the generated code will require upgrading to higher version of the k8s. I have attempted to do so in a previous PR #344. That work points to issues with the metrics adapter code used to expose cluster metrics for the 'Multi Cluster' function. I propose we differ this work until the k8s is upgraded. |
@z103cb an option may be to adapt the code-generator version, so its k8s dependencies align with the current version used by MCAD. |
After downgrading the tool versions, I was able to generate the files and effect the necessary changes in the code. This ticket does not change the version of the QuotaManagement CRDS. @astefanutti we'll have to leave that for later. |
The existing clients in
pkg/client
are not up-to-date, and do not follow current client-go standards / conventions.The client is already being used internally by MCAD for the informers, in the CodeFlare operator e2e tests, and is plan to be used in the KubeRay integration.
As the AppWrapper API is a public / user-facing API, it's important the corresponding client be up-to-date and readily available, for downstream projects to consume.
The best way to achieve this is to continuously generating the clients from the APIs.
The text was updated successfully, but these errors were encountered: