Skip to content

Generate MCAD clients #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astefanutti opened this issue Jul 26, 2023 · 3 comments · Fixed by #533
Closed

Generate MCAD clients #514

astefanutti opened this issue Jul 26, 2023 · 3 comments · Fixed by #533
Assignees
Labels

Comments

@astefanutti
Copy link
Contributor

astefanutti commented Jul 26, 2023

The existing clients in pkg/client are not up-to-date, and do not follow current client-go standards / conventions.

The client is already being used internally by MCAD for the informers, in the CodeFlare operator e2e tests, and is plan to be used in the KubeRay integration.

As the AppWrapper API is a public / user-facing API, it's important the corresponding client be up-to-date and readily available, for downstream projects to consume.

The best way to achieve this is to continuously generating the clients from the APIs.

@z103cb
Copy link
Contributor

z103cb commented Jul 31, 2023

@astefanutti I have followed the example set in this PR to generate the clients.

Unfortunately the generated code will require upgrading to higher version of the k8s. I have attempted to do so in a previous PR #344. That work points to issues with the metrics adapter code used to expose cluster metrics for the 'Multi Cluster' function.

I propose we differ this work until the k8s is upgraded.

@anishasthana, @accorvin and @tardieu

@z103cb z103cb removed their assignment Jul 31, 2023
@astefanutti
Copy link
Contributor Author

@z103cb an option may be to adapt the code-generator version, so its k8s dependencies align with the current version used by MCAD.

@z103cb z103cb self-assigned this Aug 1, 2023
@z103cb z103cb moved this from Todo to In Progress in Project CodeFlare Sprint Board Aug 1, 2023
z103cb added a commit to z103cb/multi-cluster-app-dispatcher that referenced this issue Aug 1, 2023
@z103cb z103cb moved this from In Progress to Ready For Review in Project CodeFlare Sprint Board Aug 1, 2023
@z103cb z103cb added enhancement New feature or request cleanup/refactoring labels Aug 1, 2023
@z103cb z103cb moved this from Ready For Review to In Progress in Project CodeFlare Sprint Board Aug 1, 2023
@z103cb z103cb moved this from In Progress to Ready For Review in Project CodeFlare Sprint Board Aug 2, 2023
@z103cb
Copy link
Contributor

z103cb commented Aug 2, 2023

After downgrading the tool versions, I was able to generate the files and effect the necessary changes in the code.

This ticket does not change the version of the QuotaManagement CRDS. @astefanutti we'll have to leave that for later.

@astefanutti astefanutti moved this from Ready For Review to In Review in Project CodeFlare Sprint Board Aug 2, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Project CodeFlare Sprint Board Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants