Upgraded to version v0.25.7 #344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z103cb
commented
May 2, 2023
| cmd.OpenAPIConfig = genericapiserver.DefaultOpenAPIConfig(generatedopenapi.GetOpenAPIDefinitions, openapinamer.NewDefinitionNamer(apiserver.Scheme)) | ||
| cmd := &MetricsAdapter{} | ||
| /* TODO find appropriate replacement | ||
| cmd.OpenAPIConfig = genericapiserver.DefaultOpenAPIConfig((generatedopenapi.GetOpenAPIDefinitions(), openapinamer.NewDefinitionNamer(apiserver.Scheme)) |
There was a problem hiding this comment.
@dmatch01 would you happen to know how / why we need this code ?
There was a problem hiding this comment.
In general, the metrics code is used in the multi-cluster configuration. The specific lines of code called out will require a bit more time to review.
Updated k8s version in e2e test
|
Closed the PR as is not needed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to code to upgrade api to a newer version of the API. Resolves issues #343