Skip to content

(MAINT) Add dag and workspaces icons #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2020
Merged

(MAINT) Add dag and workspaces icons #341

merged 1 commit into from
Nov 3, 2020

Conversation

sean-mckenna
Copy link
Collaborator

@sean-mckenna sean-mckenna commented Oct 14, 2020 •
edited
Loading

@sean-mckenna sean-mckenna requested a review from a team as a code owner October 14, 2020 20:06
@vine77
Copy link
Contributor

vine77 commented Oct 14, 2020

Thanks @sean-mckenna! I know you didn't design the dag logo, but it looks cropped to me and seems like that SVG of a directed acyclic graph is not really a graph if edges don't go anywhere. If it were me, I'd add an extra "parent" square node in there. But if the designer wants it that way, we can always merge and iterate.

@sean-mckenna
Copy link
Collaborator Author

@vine77 good point, calling it a dag is maybe a bit misleading here. I believe it’s deliberately designed like that but il CC @jtmuz to confirm before we merge. Thanks.

@jtmuz
Copy link
Contributor

jtmuz commented Oct 28, 2020

I've updated the dag symbol in Figma @sean-mckenna and @vine77. Also attached
i-16-dag.svg.zip

@sean-mckenna
Copy link
Collaborator Author

@vine77 updated the dag icon with the updated SVG from @jtmuz.

@vine77 vine77 self-assigned this Nov 3, 2020
vine77
vine77 approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@vine77 vine77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vine77 vine77 merged commit 65b04e0 into puppetlabs:development Nov 3, 2020
@vine77 vine77 mentioned this pull request Nov 3, 2020
Merged
@vine77 vine77 mentioned this pull request Nov 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vine77 vine77 vine77 approved these changes

Assignees

@vine77 vine77

@jtmuz jtmuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sean-mckenna @vine77 @jtmuz