Release react-components #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vine77
commented
Nov 3, 2020
vine77
commented
- [Avatar] Create Avatar component Create Avatar component #319
- [Sidebar] Add signout option to Sidebar.Footer (PDS-512) Add signout option to Sidebar Footer #338
- [Tag] Add neutral Tag (LIDAR-555) Add neutral tag #339
- [Icon] Add "dag" and "workspaces" icons (MAINT) Add dag and workspaces icons #341
- [Loading] Add a11y to Loading component (PDS-496) - Add a11y to Loading component #345
- Fix ability to npm link react-components (maint) Fix ability to npm link react-components #353
- Fix breaking tests (MAINT) Fix breaking tests #355
Converting the ToolTipHoverArea component to functional component using react hooks
Create Avatar component
(PDS-496) - Add a11y to Loading component
* (PDS-512) Add signout option to Sidebar onSignout callback prop will be called when signout button is clicked. * (PDS-512) Turn off signout button radius * (PDS-512) Add class when onClick is supplied to Sidebar.Footer Add a click class to the Profile button when an onClick prop is supplied, so that click styling such as cursor and highlighting are applied only when relevant. * (PDS-512) Remove outline from footer profile * (PDS-512) Fix Avatar changes and remove margin
Comment out the `pull_request_target` event for now because by default it runs on the PR base instead of the latest commit.
(MAINT) Fix breaking tests
Prior to this commit, @puppet/react-components made use of the npm step `prebuild` to delete the build directory prior to rebuilding the app. If another development environment was consuming a linked version of @puppet/react-components, this prebuild step caused the consuming application to rebuild immediately, and crash because the build dir was gone. With this commit, we remove the prebuild step entirely. As of Webpack 4, deleting the build dir is no longer necessary. Webpack deletes the the dir itself when adding the new files. This allows all consuming apps to utilize the linked version of @puppet/react-components during develoment. **Note:** This is the only package within the design system that used the prebuild step. I would expect linking to work as-is for all other packages, though I did not test them.
(LIDAR-555) Add neutral tag
(MAINT) Add dag and workspaces icons
(MAINT) - Converting TooltipHoverArea component to functional component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.