Skip to content

(PDS-496) - Add a11y to Loading component #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

(PDS-496) - Add a11y to Loading component #345

merged 1 commit into from
Oct 30, 2020

Conversation

jilliankeenan
Copy link
Contributor

  • Add a11y to Loading Component
  • Remove a11y from Data-Grid loading state as it now lives in loading the component itself.

@jilliankeenan jilliankeenan requested a review from a team as a code owner October 20, 2020 14:05
@vine77 vine77 self-assigned this Oct 28, 2020
vine77
vine77 approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@vine77 vine77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jilliankeenan jilliankeenan merged commit 76cfd26 into puppetlabs:development Oct 30, 2020
@vine77 vine77 mentioned this pull request Nov 3, 2020
Merged
@vine77 vine77 mentioned this pull request Nov 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vine77 vine77 vine77 approved these changes

Assignees

@vine77 vine77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jilliankeenan @vine77