Allow mysqltuner to be downloaded via a proxy #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend mysql::server::mysqltuner with an $environment, which is then passed onto staging::file, so that a proxy variable can be passed that alllows mysqltuner to be downloaded. Example usage.
'''
class { 'mysql::server::mysqltuner':
environment => 'https_proxy=http://myproxy.example.ch:80', # for download
}
'''
bmjen
previously requested changes
Dec 15, 2016
| @@ -37,6 +38,7 @@ | |||
|
|
|||
| staging::file { "mysqltuner-${_version}": | |||
| source => $_source, | |||
| environment => $environment, | |||
There was a problem hiding this comment.
Indentation needs to be fixed for this in order to pass lint.
|
@Boran Thanks for the PR! The new parameter needs to be added to the README. Also puppet-lint check is failing and needs to be addressed. |
|
Thanks for the PR, this seems to be a common issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend mysql::server::mysqltuner with an $environment, which is then passed onto staging::file, so that a proxy variable can be passed that allows mysqltuner to be downloaded. Example usage.