Skip to content

Allow mysqltuner to be downloaded via a proxy #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2016
Merged

Allow mysqltuner to be downloaded via a proxy #917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6669c75
Allow mysqltuner to be downloaded via a proxy
Boran Dec 7, 2016
b451453
align indentation
Dec 16, 2016
e5e78a1
mysql::server::mysqltuner environment setting
Boran Dec 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,9 +626,9 @@ Ensures that the resource exists. Valid values are `present`, `absent`. Defaults

The version to install from the major/MySQLTuner-perl github repository. Must be a valid tag. Defaults to 'v1.3.0'.

##### `source`
##### `environment`

Specifies the source. If not specified, defaults to `https://github.com/major/MySQLTuner-perl/raw/${version}/mysqltuner.pl`
Environment variables acive during download, e.g. to download via proxies: environment => 'https_proxy=http://proxy.example.com:80'

#### mysql::bindings

Expand Down
4 changes: 3 additions & 1 deletion manifests/server/mysqltuner.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
$ensure = 'present',
$version = 'v1.3.0',
$source = undef,
$environment = undef, # environment for staging::file
) {

if $source {
Expand Down Expand Up @@ -36,7 +37,8 @@
}

staging::file { "mysqltuner-${_version}":
source => $_source,
source => $_source,
environment => $environment,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation needs to be fixed for this in order to pass lint.

}
file { '/usr/local/bin/mysqltuner':
ensure => $ensure,
Expand Down