Implement purge_behavior parameter
#60
Conversation
This allows for specifying classes or data keys that should be present or have defined values, without removing or modifying other data already present in the node group.
|
@WhatsARanjit care to review? |
|
@WhatsARanjit does anyone else have merge access to this repo? If not, would you be open to designating a few people? |
|
@reidmv Sorry for being absent. This is fine with me, but can you whip up some corresponding tests for purging in different scenarios? Thanks. |
|
Sure, I'll take a stab at some basic tests. Will push an update when I have them. |
Also simplify merge logic
|
@WhatsARanjit a base set of tests implemented and pushed to PR. Waiting for Travis to complete; had to change the Gemfile to get a modern puppetlabs_spec_helper, waiting to see if it broke any of the other tests. |
|
@WhatsARanjit latest commit should fix the tests. I went through and updated the syntax of the small number of existing tests to use rspec mocks, rather than mocha, and unpinned some ancient gem versions. Tests should now pass. |
Update all mocking to rspec mocks, update gem versions
reidmv
force-pushed
the
merge_behaviour
branch
from
2af249a to
3ae28da
Compare
There should be no need to define a special insync? method for the classes and data properties, given that we set `should` to an appropriate value, and Ruby compares hashes in a way such that key order is irrelevant.
For easier reading
|
@WhatsARanjit thanks!! Do you think we could get a new module release with this feature? 🙂 |
|
@WhatsARanjit ping Btw, there's some neat Forge publish automation a colleague did a short bit ago that lets you auto-update the |
|
Good to go! Thanks @reidmv https://forge.puppet.com/modules/WhatsARanjit/node_manager/0.7.4 |
|
W00t!!! Awesome, thanks @WhatsARanjit!! 😄 |
With the merge of puppetlabsGH-60 adding node_groups fails with a schema error when it sends the purge_behavior parameter and is rejected by classifier. This commit adds purge_behavior to the list of filtered parameters that are built into the data structure sent to the classifier API.
With the merge of GH-60 adding node_groups fails with a schema error when it sends the purge_behavior parameter and is rejected by classifier. This commit adds purge_behavior to the list of filtered parameters that are built into the data structure sent to the classifier API.
This allows for specifying classes or data keys that should be present or have defined values, without removing or modifying other data already present in the node group.