Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node_manager's new purge_behavior parameter #134

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Conversation

reidmv
Copy link
Contributor

@reidmv reidmv commented Nov 5, 2020

This allows us to ensure the data we need, but preserve any user data that may have been set, on the node groups we manage.

Depends on puppetlabs/puppetlabs-node_manager#60 being merged and WhatsARanjit-node_manager 0.7.4 being released with an implementation of that feature.

Fixes #130
Closes #133

@puppet-community-rangefinder
Copy link

peadm::merge_ng_config_data is a function

that may have no external impact to Forge modules.

peadm::setup::node_manager is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

This allows us to ensure the data we need, but preserve any user data
that may have been set, on the node groups we manage.
@reidmv reidmv force-pushed the GH-130-purge_behavior branch from e67eda8 to c5864ad Compare January 13, 2021 19:31
@reidmv reidmv marked this pull request as ready for review January 14, 2021 00:22
@reidmv reidmv requested a review from a team as a code owner January 14, 2021 00:22
@reidmv reidmv merged commit 96a9408 into main Jan 28, 2021
@reidmv reidmv deleted the GH-130-purge_behavior branch June 1, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade deletes class parameters from PE Master (other groups too?)
1 participant