Skip to content

Expand GH-130 merge pattern to all node groups #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Expand GH-130 merge pattern to all node groups #133

wants to merge 1 commit into from

Conversation

reidmv
Copy link
Contributor

@reidmv reidmv commented Nov 4, 2020

At least for the configuration data attribute. A long-term solution is going to need to be modifying WhatsARanjit/node_manager to support a purge parameter to control this behavior on various different attributes.

@reidmv
Expand GH-130 merge pattern to all node groups

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
47c0f24 
At least for the configuration data attribute. A long-term solution is
going to need to be modifying WhatsARanjit/node_manager to support a
`purge` parameter to control this behavior on various different
attributes.
@reidmv reidmv requested a review from a team as a code owner November 4, 2020 17:10
@puppet-community-rangefinder
Copy link

peadm::merge_ng_config_data is a function

that may have no external impact to Forge modules.

peadm::setup::node_manager is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

timidri
timidri approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@timidri timidri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reidmv
Copy link
Contributor Author

reidmv commented Nov 4, 2020

The long-term solution for this issue is probably to push a purge attribute/feature into WhatsARanjit/node_manager that allows us to indicate we want data merged rather than overwritten. I'm holding off merging this PR on hearing from a customer whether or not they need it. If there is not immediate urgency, I'm going to hold off merging this and see what it would take to get a purge feature implemented in node_manager instead.

@reidmv reidmv mentioned this pull request Nov 5, 2020
Merged
@reidmv
Copy link
Contributor Author

reidmv commented Jan 14, 2021

Closing in favor of #134

@reidmv reidmv closed this Jan 14, 2021
@reidmv reidmv deleted the GH-130-pt2 branch June 1, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timidri timidri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reidmv @timidri