Determine validation key from asc signature file #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust message language, add message for moving temp file into target location on successful download
Rather than expecting that downloaded files will be signed with a known key, simply use the key from the signature asc file. The purpose of this validation isn't to validate authenticity. It is only to validate digest.
davidsandilands
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than expecting that downloaded files will be signed with a known key, simply use the key from the signature asc file.
The purpose of this validation isn't to validate authenticity. It is only to validate digest. Because the packages we download have been signed with multiple different keys over the years, it isn't possible to anticipate a default key and expect it to work for all downloads.
Fixes #216