Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine validation key from asc signature file #219

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Determine validation key from asc signature file #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb8a795
Improve logging of peadm::download
reidmv Oct 1, 2021
4e3e52a
Determine signing key from asc file
reidmv Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions tasks/download.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,9 @@
"description": "Whether to check the integrity of the downloaded file",
"default": true
},
"key_id": {
"type": "String",
"description": "The GPG key ID to use when verifying the download",
"default": "4528B6CD9E61EF26"
},
"key_server": {
"type": "String",
"description": "The GPG keyserver to retrieve the GPG key from",
"description": "The GPG keyserver to retrieve GPG keys from",
"default": "hkp://keyserver.ubuntu.com:11371"
}
},
Expand Down
14 changes: 10 additions & 4 deletions tasks/download.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ EX_UNAVAILABLE=69
verify-file() {
local sig="$1"
local doc="$2"
local keyid

# The GPG binary is required to be present in order to perform file download
# verification. If it is not present, return EX_UNAVAILABLE.
Expand All @@ -19,8 +20,12 @@ verify-file() {
# The verification key must be present, or it must be possible to download it
# from the keyserver to perform file verification. If it is not present,
# return EX_UNAVAILABLE.
if ! { gpg --list-keys "$PT_key_id" || gpg --keyserver "$PT_key_server" --recv-key "$PT_key_id"; } then
echo "Unable to download verification key ${PT_key_id}"
keyid=$(gpg --list-packets --with-colons "$sig" | awk '/:signature packet:/{print $NF; exit 0}')
if [[ -z "$keyid" ]]; then
echo "Unable to determine verification key from ${sig}"
return "$EX_UNAVAILABLE"
elif ! { gpg --list-keys "$keyid" || gpg --keyserver "$PT_key_server" --recv-key "$keyid"; } then
echo "Unable to download verification key ${keyid}"
return "$EX_UNAVAILABLE"
fi

Expand All @@ -37,14 +42,15 @@ verify-file() {
download() {
printf '%s\n' "Downloading: ${1}"
tmp_file=$(mktemp)
echo "Temporary file created at: ${tmp_file}"
echo "Downloading to temporary file ${tmp_file}"

if curl -s -f -L -o ${tmp_file} "$1"; then
echo "Moving ${tmp_file} to target path ${2}"
mv "${tmp_file}" "$2"
return 0
else
echo "Error: Curl has failed to download the file"
echo "Removing temporary file: ${tmp_file}"
echo "Removing temporary file ${tmp_file}"
rm "${tmp_file}"
return 1
fi
Expand Down