Set additional rules on replica when adding compiler #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a compiler using the add_compiler plan and a replica is provisioned, it is necessary to add the new compiler's certificate name to the PuppetDB instance that will serve as replica for the compiler.
Ensure the global hiera.yaml is synced from primary so that data in console is enabled.
ody
force-pushed
the
add_compiler_run_puppet
branch
3 times, most recently
from
aa27289 to
2419e2e
Compare
timidri
suggested changes
Jun 17, 2022
spec/plans/add_compiler_spec.rb
Outdated
| @@ -33,8 +47,9 @@ def allow_standard_non_returning_calls | |||
|
|
|||
| # {"install_flags"=> | |||
| # ["--puppet-service-ensure", "stopped", | |||
| # "extension_requests:1.3.6.1.4.1.34380.1.3.13=pe_compiler", "extension_requests:1.3.6.1.4.1.34380.1.1.9813=A", "main:certname=compiler"], "server"=>"primary"} | |||
| # "extenion_requests:1.3.6.1.4.1.34380.1.3.13=pe_compiler", "extension_requests:1.3.6.1.4.1.34380.1.1.9813=A", "main:certname=compiler"], "server"=>"primary"} | |||
There was a problem hiding this comment.
@ody Is there a typo here? Is this an inadvertent change?
There was a problem hiding this comment.
Inadvertently deletion of the letter s in extension_requests.
spec/plans/add_compiler_spec.rb
Outdated
|
|
||
| expect_plan('peadm::util::sync_global_hiera') |
There was a problem hiding this comment.
What does expect_plan with no further arguments do?
There was a problem hiding this comment.
I believe it just ensures it is run but ignores any specifics like success, failure, or how many times it actually ran. To make is more specific, I'll add the number of times it is expected to run. The plan doesn't return anything and parameters are just source and target. Mocking it is simply required because if it isn't, the underlying tasks fail because they require reading a file off disk
Introduced new things that needed to be mocked to finish successfully
ody
force-pushed
the
add_compiler_run_puppet
branch
from
2419e2e to
f5ae8a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix that ensures compiler is functional when deployed using
add_compilerand a replica server is present