configure classifier data in global hiera.yaml #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkishel
commented
Jan 17, 2020
So that if the default hiera.yaml changes, the logic will still work, and the source of truth for the contents of hiera.yaml in a deployment managed by peadm is not the peadm module itself.
npwalker
reviewed
Jan 17, 2020
|
|
||
| cat <<EOS | ||
| { | ||
| "content": $(python -c "import json; print json.dumps(open('$outfile','r').read())") |
There was a problem hiding this comment.
fwiw, python isn't available by default on rhel 8... I'm actually confused what was wrong with actually using cat here.
There was a problem hiding this comment.
That's good to know. Hmm.
Python is needed/used because the result returned needs to be JSON, and special characters like newlines need to be JSON encoded to be returned.
Looks like python isn't available by default on Ubuntu 18.04 either.
I think the workaround for now is gonna have to be shipping a Ruby implementation of this task. At the moment we only use it after Puppet is installed, so that should work ok.
There was a problem hiding this comment.
FWIW /usr/bin/python3 is installed on my Platform9 Ubuntu VMs.
Yes, ruby ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #20