-
Notifications
You must be signed in to change notification settings - Fork 54
configure classifier data in global hiera.yaml #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"description": "Read the contents of a file", | ||
"parameters": { | ||
"path": { | ||
"type": "String", | ||
"description": "Path to the file to read" | ||
} | ||
}, | ||
"input_method": "environment" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
#!/bin/bash | ||
|
||
main() { | ||
cat "$PT_path" | ||
} | ||
|
||
outfile=$(mktemp) | ||
main "$@" >"$outfile" 2>&1 | ||
exit_code=$? | ||
|
||
cat <<EOS | ||
{ | ||
"content": $(python -c "import json; print json.dumps(open('$outfile','r').read())") | ||
} | ||
EOS | ||
|
||
rm "$outfile" | ||
exit $exit_code |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, python isn't available by default on rhel 8... I'm actually confused what was wrong with actually using
cat
here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good to know. Hmm.
Python is needed/used because the result returned needs to be JSON, and special characters like newlines need to be JSON encoded to be returned.
Looks like
python
isn't available by default on Ubuntu 18.04 either.I think the workaround for now is gonna have to be shipping a Ruby implementation of this task. At the moment we only use it after Puppet is installed, so that should work ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW
/usr/bin/python3
is installed on my Platform9 Ubuntu VMs.Yes, ruby ...