(PUP-11752) fqdn_rand_string_spec.rb relies on legacy fqdn fact

[AriaXLi]

No description provided.

[smortex]

Good catch, this will be needed with the next version of Puppet.

Minor style issue, also the commit message needs need adjusting 😄

[joshcooper]

Ah the expectation needs to be different based on the version of puppet (before and after this change puppetlabs/puppet@c0d2560). So something like

if Puppet::PUPPETVERSION.to_f < 7.23
  allow(scope).to receive(:lookupvar).with('::fqdn', {}).and_return(host)
else
  allow(scope).to receive(:lookupvar).with('facts', {}).and_return({ 'networking' => { 'fqdn' => host } })
end

Or there may be a better way to stub out the facts using RspecPuppetFacts?

[ekohl]

Perhaps this function should just mock fqdn_rand? It really is fqdn_rand which gets the fact, so we don't care about the internal implementation:

puppetlabs-stdlib/lib/puppet/parser/functions/fqdn_rand_string.rb

Line 37 in dfd9b30

rand_string += charset[function_fqdn_rand([charset.size, (args + [current.to_s]).join(':')]).to_i]

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[joshcooper]

PR #1308 was merged and supersedes this work, so closing this PR.