Stdlib::Http::Method: Add new type for http methods #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ekohl
reviewed
Mar 10, 2023
b4ldr
force-pushed
the
feature/https_method
branch
from
db22075 to
e588a1d
Compare
|
i'm guessing the ci issue is unrelated? |
ekohl
reviewed
Mar 10, 2023
|
You can ignore mend, but I wonder why the unit test is failing. |
|
thanks, the failed spec test relate to |
|
Oh no, that's #1294. |
bastelfreak
previously approved these changes
Mar 10, 2023
bastelfreak
reviewed
Mar 10, 2023
| type Stdlib::HttpStatus = Integer[100, 599] | ||
| # @deprecated Use Stdlib::Http::Status | ||
| # @see Stdlib::Http::Status | ||
| type Stdlib::HttpStatus = Stdlib::Http::Status |
There was a problem hiding this comment.
after this is merged, can you raise a new PR that removes this old type? Then we can keep it open until the next major release and won't forget it.
There was a problem hiding this comment.
sure will do, ill leave this open for now so i dont forget
This PR creates new new resources: * Stdlib::Http::Method for validating http methods * Stdlib::Http::Status This is just a copy of Stdlib::Httpstatus * make Stdlib::Httpstatus and alias to Stdlib::Http::Status Ideally we would deprecate Stdlib::Httpstatus in favour of Stdlib::Http::Status Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
b4ldr
force-pushed
the
feature/https_method
branch
from
e588a1d to
89d78c1
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates new new resources:
This PR re-intorduces #1192 which i apparently nuked in #1193
Fixes #1297