Skip to content

irradiance.liujordan function doesn't use pressure arg #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KonstantinTr opened this issue Oct 18, 2017 · 2 comments
Closed

irradiance.liujordan function doesn't use pressure arg #386

KonstantinTr opened this issue Oct 18, 2017 · 2 comments
Labels
api bug
Milestone
0.5.2

Comments

@KonstantinTr
Copy link
Contributor

I believe pressure has no usage in this function:

image

The only call of liujordan is from cloud_cover_to_irradiance_liujordan of forecast.py doesn't pass pressure
image

Is there any chance that pressure should be used somewhere within function?
@cwhanse
Copy link
Member

cwhanse commented Oct 18, 2017

No, atmospheric pressure is not used in the Liu – Jordan decomposition model.

If you are fixing this, please correct the spelling : tao should be tau.

Thanks!

@KonstantinTr
Copy link
Contributor Author

@cwhanse Thanks for the feedback. I'll fix tau spelling as well.

@wholmgren wholmgren added this to the 0.5.2 milestone Oct 18, 2017
KonstantinTr added a commit to KonstantinTr/pvlib-python that referenced this issue Oct 26, 2017
@KonstantinTr
fix for issue pvlib#386
c48153d
KonstantinTr added a commit to KonstantinTr/pvlib-python that referenced this issue Oct 26, 2017
@KonstantinTr
what's new for issue pvlib#386
9514a31
@KonstantinTr KonstantinTr mentioned this issue Oct 26, 2017
Merged
6 tasks
KonstantinTr added a commit to KonstantinTr/pvlib-python that referenced this issue Oct 26, 2017
@KonstantinTr
test update for issue pvlib#386
dcb72f5
wholmgren pushed a commit that referenced this issue Nov 13, 2017
@KonstantinTr @wholmgren
removes unused pressure arg from Irradiance.liujordan function (#389)
726cf07 
* fix for issue #343

Now, passed 'offset' parameter are used instead of it's default value.

* test for issue #343

* solar_position_method passed to basic_chain wasn't used causing
execution of solarposition.get_solarposition with default 'nrel_numpy'
value in all cases.

* Update modelchain.py

doc string fixes for modelchain.basic_chain function

* Update v0.5.1.rst

* Update v0.5.1.rst

* Update v0.5.1.rst

* Update v0.5.1.rst

* Update v0.5.1.rst

* fix for issue #386

* what's new for issue #386

* test update for issue #386

* Update conftest.py

* Update test_irradiance.py

* Update v0.5.2.rst

* Update v0.5.2.rst
@cwhanse cwhanse mentioned this issue Dec 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api bug
Projects
None yet
Milestone
0.5.2
Development

No branches or pull requests
3 participants
@wholmgren @cwhanse @KonstantinTr