removes unused pressure arg from Irradiance.liujordan function #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, passed 'offset' parameter are used instead of it's default value.
execution of solarposition.get_solarposition with default 'nrel_numpy' value in all cases.
update from pvlib-python
doc string fixes for modelchain.basic_chain function
update to rev 0.5.1.
update from pvlib
update form pvlib's master
…esn't-use-pressure-arg' into irradiance.liujordan-function-doesn't-use-pressure-arg
wholmgren
reviewed
Oct 26, 2017
| @@ -14,6 +14,7 @@ Enhancements | |||
| Bug fixes | |||
| ~~~~~~~~~ | |||
| * fixed redeclaration of test_simplified_solis_series_elevation (:issue:`387`) | |||
| * removed unused 'pressure' arg from irradiance.liujordan function (:issue:`386`) | |||
There was a problem hiding this comment.
I suggest putting this in the API changes section to give it a little more visibility.
pvlib/test/test_irradiance.py
Outdated
| @@ -201,8 +201,7 @@ def test_liujordan(): | |||
| columns=['ghi', 'dni', 'dhi'], | |||
| index=[0]) | |||
| out = irradiance.liujordan( | |||
| pd.Series([10]), pd.Series([0.5]), pd.Series([1.1]), | |||
| pressure=93000., dni_extra=1400) | |||
| pd.Series([10]), pd.Series([0.5]), pd.Series([1.1]),dni_extra=1400) | |||
|
I don't like that tests fail on python 3. When I run on my local windows machine I've got: 457 total, 1 failed, 5 ignored, 451 passed I've created an issue #390 for the failed test. |
|
Looks like we've resolved all the testing issues, so I'm going to go ahead and merge this. Thanks for the fix @KonstantinTr |
KonstantinTr
deleted the
irradiance.liujordan-function-doesn't-use-pressure-arg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffand/or landscape.io linting service.docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.