Skip to content

irradiance.total_irrad signature is incorrect #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cwhanse opened this issue Feb 12, 2018 · 0 comments
Closed

irradiance.total_irrad signature is incorrect #423

cwhanse opened this issue Feb 12, 2018 · 0 comments
Labels
bug documentation easy
Milestone
0.5.2

Comments

@cwhanse
Copy link
Member

cwhanse commented Feb 12, 2018

Function signature states

Determine diffuse irradiance from the sky on a tilted surface.

However, the function returns a dataframe with all components of POA irradiance: beam, sky diffuse, ground reflected.
@cwhanse cwhanse mentioned this issue Feb 12, 2018
Closed
@wholmgren wholmgren added this to the 0.5.2 milestone Feb 12, 2018
@wholmgren wholmgren added the easy label Feb 12, 2018
@cwhanse cwhanse mentioned this issue Feb 12, 2018
Merged
6 tasks
wholmgren pushed a commit that referenced this issue Feb 13, 2018
@cwhanse @wholmgren
Closes #423 total_irrad docstring (#425)
8a4aaca 
* Fix total_irrad docstring

* Correct formatting in irradiance.py; update whatsnew.rst

* Update irradiance.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation easy
Projects
None yet
Milestone
0.5.2
Development

No branches or pull requests
2 participants
@wholmgren @cwhanse