Closes #423 total_irrad docstring #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix total_irrad docstring
Fix formatting in irradiance.py
|
Done I think. |
wholmgren
reviewed
Feb 12, 2018
pvlib/irradiance.py
Outdated
| @@ -294,13 +294,20 @@ def total_irrad(surface_tilt, surface_azimuth, | |||
| model='isotropic', | |||
| model_perez='allsitescomposite1990', **kwargs): | |||
| r""" | |||
| Determine diffuse irradiance from the sky on a tilted surface. | |||
| Determine total in-plane irradiance and it's beam, sky diffuse and ground | |||
|
I knew that :) |
|
Yes, of course, I'm sure it was intended to test the reviewers -- thanks! |
mikofski
reviewed
Aug 3, 2018
| @@ -16,6 +16,7 @@ Bug fixes | |||
| * fixed redeclaration of test_simplified_solis_series_elevation (:issue:`387`) | |||
| * physicaliam now returns a Series if called with a Series as an | |||
| argument. (:issue:`397`) | |||
| * corrected docstring for irradiance.total_irrad (:issue: '423') | |||
There was a problem hiding this comment.
pls change single quotes around #423 to backticks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pvlib python pull request guidelines
Thank you for your contribution to pvlib python!
You may submit a pull request with your code at any stage of completion, however, before the code can be merged the following items must be addressed:
git diff upstream/master -u -- "*.py" | flake8 --diffand/or landscape.io linting service.docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.Please don't hesitate to ask for help if you're unsure of how to accomplish any of the above. You may delete all of these instructions except for the list above.
Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):