Specified encoding in setup.py calls of open() #3137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The files of the project are encoded in UTF-8, yet the opening of files in the
setup.py
does not specify this encoding. When trying to install on a system with a non-UTF-8 locale usingpip install pybind11/.
the process fails with the the following error:Specifying that the files should be opened using UTF-8 encoding fixes the problem.
Suggested changelog entry: