Skip to content

Specified encoding in setup.py calls of open() #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Specified encoding in setup.py calls of open() #3137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
785c694
Specified encoding in setup.py calls of open()
Jul 20, 2021
66c3aa0
Fix for Python2
ka-bo Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import subprocess
import sys
import tempfile
import io

import setuptools.command.sdist

Expand Down Expand Up @@ -70,7 +71,7 @@ def build_expected_version_hex(matches):
version = loc["__version__"]

# Verify that the version matches the one in C++
with open("include/pybind11/detail/common.h") as f:
with io.open("include/pybind11/detail/common.h", encoding="utf8") as f:
matches = dict(VERSION_REGEX.findall(f.read()))
cpp_version = "{MAJOR}.{MINOR}.{PATCH}".format(**matches)
if version != cpp_version:
Expand Down