Add missing error handling to module_::def_submodule
#3973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
reviewed
May 26, 2022
include/pybind11/pybind11.h
Outdated
| if (this_name == nullptr) { | ||
| throw error_already_set(); | ||
| } | ||
| std::string full_name = std::string(this_name) + "." + name; |
There was a problem hiding this comment.
Suggested change
| std::string full_name = std::string(this_name) + "." + name; | |
| std::string full_name = std::string(this_name) + '.' + name; |
Skylion007
reviewed
May 26, 2022
| if (!submodule) { | ||
| throw error_already_set(); | ||
| } | ||
| auto result = reinterpret_borrow<module_>(submodule); |
There was a problem hiding this comment.
For reference, wouldn't you also been able to do?
if(!result){
throw error_already_set();
}
This looks good either way though.
There was a problem hiding this comment.
IIU your question correctly, that would assume reinterpret_borrow<module_> is OK with nullptr, and does not care about the active error. While that is usually true, what if someone temporarily adds debugging code to reinterpret_borrow, or the module_ constructor in this case? Their fault, of course, but why build a trap like that?
Generally, I think it is bad style to separate error handling from the source of the error more than necessary.
Skylion007
approved these changes
May 26, 2022
rwgk
force-pushed
the
def_submodule_error_handling
branch
from
b8a16e3 to
dbbe9d1
Compare
Skylion007
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from PR #3964, where the missing error handling happened to cause some confusion.
Suggested changelog entry:
``module_::def_submodule`` was missing proper error handling. This is fixed now.