Skip to content

TEST: test passes on PyPy macOS #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025
Merged

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Mar 18, 2025

Description

test_cross_module_exception_translator now passes on macOS + PyPy, see PyPy-specific CI run. Probably not important enough for a changelog blurb?

Suggested changelog entry:

@rwgk
Copy link
Collaborator

rwgk commented Mar 18, 2025

@mattip What is different between e.g.

?

Do we need to update our .github/workflows/ci.yml here?

It'd be great if you could drop pypy-3.8, pypy-3.9, and update the jobs for pypy-3.10 and pypy-3.11 so that they are most useful for your purposes. I think. @henryiii for visibility.

@mattip
Copy link
Contributor Author

mattip commented Mar 18, 2025

Blehh. I tried to make the CI runs as compatible as I could. I don't know what is different. Maybe because there are some transient dependencies that are different, like in #5568?

I will drop PyPy3.8, PyPY3.9 in a commit, once I can figure out why the pypy/binary-tests CI is passing while this one fails.

@rwgk
Copy link
Collaborator

rwgk commented Mar 18, 2025

Blehh. I tried to make the CI runs as compatible as I could. I don't know what is different. Maybe because there are some transient dependencies that are different, like in #5568?

I will drop PyPy3.8, PyPY3.9 in a commit, once I can figure out why the pypy/binary-tests CI is passing while this one fails.

Off the top of my head, I cannot think of anything. We don't do anything special, beyond what's done from cmake, and what you see in our ci.yml.

@rwgk
Copy link
Collaborator

rwgk commented Mar 18, 2025

I forgot to mention, test_exceptions.py::test_cross_module_exception_translator has been a bit of a troublemaker, see e.g.

I never got to the bottom of it.

Maybe just make the strict XFAIL non-strict?

Co-authored-by: Henry Schreiner <[email protected]>
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this. We can remove the 3.8, 3.9 PyPy testing separately.

@rwgk rwgk merged commit 97022f8 into pybind:master Mar 21, 2025
80 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Mar 21, 2025
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants