-
Notifications
You must be signed in to change notification settings - Fork 281
add timedelta type #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add timedelta type #137
Conversation
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 97.66% 97.71% +0.05%
==========================================
Files 43 44 +1
Lines 4231 4422 +191
Branches 30 31 +1
==========================================
+ Hits 4132 4321 +189
- Misses 99 101 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, thank so much.
A few things here, you also need to update _types.py
.
@samuelcolvin These problems were fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, a few more things to fix.
I might merge #138 which will conflict with this, if so I'll fix conflicts for you.
also worth noting that while testing this, I found some int overflow bugs speedate, see pydantic/speedate#11 I'll make a new release of speedate in the coming days. |
@samuelcolvin when fix it , found a speedate bug ,look pydantic/speedate#12 |
I've released speedate v0.5.0 which fixes both those problems. |
@samuelcolvin I don't know, i have do nothing...... i will try resolve those conflicts |
I found the settings. Now you can push my branch. |
great, I've pushed, should save your resolving those changes. |
This is my first rust PR,unskilled in rust. |
Then I'm really impressed by what you've done here! I've updated I've also resolved conflicts. I'll have another look later, but I think this is nearly ready to merge 🎉 . |
Thanks so much for all your work on this. 🙏 Feel free to work on other issues which interest you, or create an issue if you think you see a bug or potential feature. |
#122 implement timedelta