Skip to content

Error improvements #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 2, 2022
Merged

Error improvements #138

merged 11 commits into from
Jul 2, 2022

Conversation

samuelcolvin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #138 (18ba518) into main (b95b3d2) will increase coverage by 0.01%.
The diff coverage is 99.25%.

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   97.44%   97.45%   +0.01%     
==========================================
  Files          41       41              
  Lines        4068     4007      -61     
  Branches       28       28              
==========================================
- Hits         3964     3905      -59     
+ Misses        104      102       -2     
Impacted Files Coverage Δ
src/build_tools.rs 98.43% <ø> (ø)
src/errors/mod.rs 92.30% <ø> (ø)
src/input/input_abstract.rs 100.00% <ø> (ø)
src/validators/nullable.rs 100.00% <ø> (ø)
src/validators/union.rs 98.41% <ø> (ø)
src/validators/function.rs 95.00% <93.75%> (+0.02%) ⬆️
src/errors/line_error.rs 95.08% <95.65%> (-2.04%) ⬇️
src/input/input_python.rs 98.20% <97.67%> (-0.02%) ⬇️
src/errors/kinds.rs 100.00% <100.00%> (ø)
src/errors/location.rs 100.00% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95b3d2...18ba518. Read the comment docs.

* move error context into enum

* tweak

* simplify error rendering

* use static strings where possible

* tweak error kind rendering

* improve coverage

* improve coverage

* cleanup
@samuelcolvin samuelcolvin marked this pull request as ready for review July 2, 2022 12:08
@samuelcolvin samuelcolvin merged commit d3a6bf3 into main Jul 2, 2022
@samuelcolvin samuelcolvin deleted the error-improvements branch July 2, 2022 13:46
@samuelcolvin samuelcolvin mentioned this pull request Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant