move error context into enum #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## error-improvements #139 +/- ##
======================================================
+ Coverage 97.22% 97.35% +0.12%
======================================================
Files 42 41 -1
Lines 4043 4007 -36
Branches 28 28
======================================================
- Hits 3931 3901 -30
+ Misses 112 106 -6
Continue to review full report at Codecov.
|
samuelcolvin
added a commit
that referenced
this pull request
Jul 2, 2022
* making val_line_error a function * simplify context * simplify location * better error creation * cleanup * update context! macro * more cleanup * move error context into enum (#139) * move error context into enum * tweak * simplify error rendering * use static strings where possible * tweak error kind rendering * improve coverage * improve coverage * cleanup * remove unused code * correct imports * cleanup location logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.