Skip to content

flaky accessibility tests: tab traps (notebooks) #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
drammock opened this issue Mar 6, 2025 · 1 comment · Fixed by #2160
Closed

flaky accessibility tests: tab traps (notebooks) #2158

drammock opened this issue Mar 6, 2025 · 1 comment · Fixed by #2160
Labels
tag: accessibility Issues related to accessibility issues or efforts tag: testing Issues related to PST testing

Comments

@drammock
Copy link
Collaborator

drammock commented Mar 6, 2025 •
edited
Loading

I have noticed some flaky accessibility tests re tab traps (notebooks), I wonder if https://github.com/pydata/pydata-sphinx-theme/actions/runs/13659445744/job/38186908516#step:4:672 is related to #2139 (comment) at all @gabalafou

Originally posted by @trallard in #2077 (comment)
@drammock drammock mentioned this issue Mar 6, 2025
Merged
@drammock
Copy link
Collaborator Author

drammock commented Mar 6, 2025

xref to #2153 (comment)

This might be the cause of the failing a11y tests in CI (I have not dug into those, but they fail on the tab stop tests)

@trallard trallard added tag: accessibility Issues related to accessibility issues or efforts tag: testing Issues related to PST testing labels Mar 7, 2025
@gabalafou gabalafou mentioned this issue Mar 10, 2025
Merged
trallard pushed a commit that referenced this issue Mar 11, 2025
@gabalafou
BUG - Use Playwright expect() for code block tab stop tests (#2160)
255bc06 
Maybe fixes #2158.

This takes advantage of Playwright's ability to wait for a condition to
be true rather than hard-coding manual wait times with the
`page.wait_for_timeout()` function.

From the Playwright docs:

> Playwright includes assertions that will wait until the expected
condition is met. Using these assertions allows making the tests
non-flaky and resilient.
> -[Writing Tests:
Assertions](https://playwright.dev/python/docs/writing-tests#assertions)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tag: accessibility Issues related to accessibility issues or efforts tag: testing Issues related to PST testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Playwright expect() for code block tab stop tests gabalafou/pydata-sphinx-theme
2 participants
@drammock @trallard