Skip to content

MAINT - Update actions/workflows SHAs #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 6, 2025

Conversation

trallard
Copy link
Collaborator

@trallard trallard commented Mar 5, 2025

This follows #2077 as our actions and workflows needed re-pinning after merging this branch. Included:

  • 📌 Pin our actions to a concrete SHA
  • 👷 Add test to publish workflow

@trallard trallard added tag: dependencies Pull requests that update a dependencies or that is related to PST dependencies kind: maintenance Improving maintainability and reducing technical debt tag: CI Pull requests that update GitHub Actions code labels Mar 5, 2025
@trallard trallard marked this pull request as ready for review March 6, 2025 18:24
@trallard
Copy link
Collaborator Author

trallard commented Mar 6, 2025

This is now ready for review. It adds SHAs to the actions/workflows after we merged #2077
I checked that the workflows work as expected (see in my own fork) https://github.com/trallard/pydata-sphinx-theme/actions/runs/13705408971/job/38329387415

Our prerelease workflow is failing in main so it would be best to merge quite soon.

@trallard trallard requested a review from drammock March 6, 2025 18:26
Comment on lines +58 to +68
# Run tests on the built package (which will be later uploaded to PyPI)
- name: "Install PST from wheel and test"
env:
BAIPP_DIST: ${{ steps.baipp.outputs.dist }}
run: |
dist_loc="${BAIPP_DIST}"
# calling with --installpkg so we can use the already built package
tox run -e py312-tests-no-cov \
--installpkg $dist_loc/*.whl \
-- --deselect tests/test_build.py::test_translations

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this to the prerelease workflow but should have added them to the publish one too for some final quality checks on the packaged artefacts

Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging on the assumption that the failing a11y CIs will be tracked in #2158

@drammock drammock merged commit 61e4e5f into pydata:main Mar 6, 2025
26 of 31 checks passed
@trallard trallard deleted the trallard/patch-release-workflow branch March 7, 2025 19:36
gabalafou pushed a commit to gabalafou/pydata-sphinx-theme that referenced this pull request Mar 10, 2025
This follows pydata#2077 as
our actions and workflows needed re-pinning after merging this branch.
Included:

- **:pushpin: Pin our actions to a concrete SHA**
- **:construction_worker: Add test to publish workflow**
gabalafou added a commit that referenced this pull request Mar 10, 2025
I think this is what caused the following error message in [one of the failing checks](https://github.com/pydata/pydata-sphinx-theme/actions/runs/13705550329/job/38329838641#step:5:22) for #2151:

> Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
trallard added a commit that referenced this pull request Mar 11, 2025
I think this is what caused the following error message in [one of the
failing
checks](https://github.com/pydata/pydata-sphinx-theme/actions/runs/13705550329/job/38329838641#step:5:22)
for #2151:

> Error: Failed to CreateArtifact: Received non-retryable error: Failed
request: (409) Conflict: an artifact with this name already exists on
the workflow run

<!-- readthedocs-preview pydata-sphinx-theme start -->
----
📚 Documentation preview 📚:
https://pydata-sphinx-theme--2161.org.readthedocs.build/en/2161/

<!-- readthedocs-preview pydata-sphinx-theme end -->

Co-authored-by: Tania Allard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: maintenance Improving maintainability and reducing technical debt tag: CI Pull requests that update GitHub Actions code tag: dependencies Pull requests that update a dependencies or that is related to PST dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants