Skip to content

Special-case xarray so that its repr_html shows up #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
choldgraf opened this issue Oct 22, 2020 · 1 comment · Fixed by #275
Closed

Special-case xarray so that its repr_html shows up #274

choldgraf opened this issue Oct 22, 2020 · 1 comment · Fixed by #275

Comments

@choldgraf
Copy link
Collaborator

In executablebooks/sphinx-book-theme#238 we uncovered that the xarray package uses a kind-of hacky approach to its repr_html outputs that causes them to not show up if bootstrap is loaded.

In this comment @benbovy described a simple hack to get around this, which is to add a CSS rule like:

.xr-wrap { display: block !important }

That would make xarray outputs work with this theme.

I'm +1 on special-casing xarray here since they are in the pydata ecosystem. I'll open a PR to do this in a day or so, but wanted to see if anyone particularly objects to this approach (we all know that xarray is doing something kinda hacky here, but this still seems like the easiest path forward for all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants