Skip to content

no html reprs in rendered docs #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dcherian opened this issue Jul 20, 2020 · 3 comments · Fixed by #132
Closed

no html reprs in rendered docs #57

dcherian opened this issue Jul 20, 2020 · 3 comments · Fixed by #132
Labels
documentation Improvements or additions to documentation upstream issue

Comments

@dcherian
Copy link
Contributor

https://cf-xarray.readthedocs.io/en/latest/examples/introduction.html

Not sure why.
@dcherian dcherian added the help wanted Extra attention is needed label Jul 20, 2020
@benbovy
Copy link
Member

benbovy commented Aug 6, 2020 •
edited
Loading

It looks like bootstrap 4 (used by sphinx-book-theme) forces all html elements with hidden attributes to be actually hidden (source), so the hack in pydata/xarray#4053 does not work here (the result is even worse).

I guess that a workaround would be to add some custom CSS such as .xr-wrap { display: block !important }, assuming that custom CSS is loaded after Bootstrap's CSS. Not ideal, though, it looks like a hack on top of another hack.

@dcherian dcherian mentioned this issue Aug 6, 2020
Closed
@dcherian
Copy link
Contributor Author

dcherian commented Aug 6, 2020

Thanks @benbovy . I've opened an issue at xarray for more discussion & visibility

@dcherian dcherian added upstream issue and removed help wanted Extra attention is needed labels Aug 6, 2020
dcherian added a commit to dcherian/cf-xarray that referenced this issue Aug 7, 2020
@dcherian
Use text repr in example notebook.
9920c68 
Work around xarray-contrib#57
@dcherian dcherian mentioned this issue Aug 7, 2020
Merged
dcherian added a commit that referenced this issue Aug 8, 2020
@dcherian
docs overhaul (#74)
ed18209 
1. Use text repr in example notebook to work around #57
2. Allow nbsphinx to fail. I use "raises-error" tag in the cell metadata.
3. Move introduction notebook to top-level.
4. Add logo!
5. Avoid faceting by time to avoid pandas 1.1 incompatibility. RTD's install strategy ends up updating pandas even if I pin it :/
@dcherian dcherian added the documentation Improvements or additions to documentation label Oct 13, 2020
@dcherian
Copy link
Contributor Author

Fixed upstream: executablebooks/sphinx-book-theme#238 pydata/pydata-sphinx-theme#274 pydata/pydata-sphinx-theme#275

@dcherian dcherian mentioned this issue Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation upstream issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update doc build dcherian/cf-xarray
2 participants
@dcherian @benbovy