Skip to content

[wip] Add Lighthouse in CI #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

bollwyvl
Copy link
Collaborator

Thanks again for this theme!

This adds some more GitHub Actions to run Lighthouse against the built artifacts, as a start to #61, and should help inform performance and SEO as well:

This needs an upstream PR to get merged on larsoner/circleci-artifacts-redirector-action, so that we can use the circle URL in other steps. I've temporarily pointed it at my branch.

I've also added a few quick-win role and aria-labels to the navs, and done a little bit of looking into some of the things I determined from running local Lighthouse.

@bollwyvl bollwyvl changed the title Add lighthouse [wip] Add Lighthouse in CI Jun 20, 2020
@bollwyvl
Copy link
Collaborator Author

Looks like it's a timescale thing: the status job is always getting run from master, so it does not include these changes, and pull_request won't have the right information to work with circle. hm....

@hoetmaaiers
Copy link
Collaborator

Is this update also available in the Github Checks part (in this PR)?

@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Jun 22, 2020 via email

@hoetmaaiers
Copy link
Collaborator

Ok, not to strange indeed.
The addition of Lighthouse in any case receives a +1 from me.

@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Jun 22, 2020 via email

@choldgraf
Copy link
Collaborator

I am a +1 on anything that gives us iterative improvements without adding much complexity to our build process, or maintenance burden :-)

@choldgraf
Copy link
Collaborator

I think that this one is no longer needed, since we now do have lighthouse checks in our integration tests. I'll close it, but please re-open or let me know if this was adding a different functionality as well!

@choldgraf choldgraf closed this Aug 28, 2021
@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Aug 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants