-
Notifications
You must be signed in to change notification settings - Fork 339
[wip] Add Lighthouse in CI #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like it's a timescale thing: the |
Is this update also available in the Github Checks part (in this PR)? |
No, it doesn't work (yet) because the status event is decoupled from the pr
cycle... It needs some crucial bits from the circle webhook payload.
I think, if merged, it would show up, just like the redirector, but it's
hard to say.
|
Ok, not to strange indeed. |
Cool, the upstream pr got merged/released.
Perhaps I do a smaller PR chain that:
- just runs/publishes the report
- add the score thresholds without any changes
- adds the few small fixes, updates the thresholds
The threshold changes wouldn't be applied until after merge, but the
alternatives (running headless chrome with lighthouse installed) seem...
Hard, and less representative of a production host (http/2, ssl).
|
I am a +1 on anything that gives us iterative improvements without adding much complexity to our build process, or maintenance burden :-) |
I think that this one is no longer needed, since we now do have lighthouse checks in our integration tests. I'll close it, but please re-open or let me know if this was adding a different functionality as well! |
Yup, don't know why this is still open, close away
|
Thanks again for this theme!
This adds some more GitHub Actions to run Lighthouse against the built artifacts, as a start to #61, and should help inform performance and SEO as well:
This needs an upstream PR to get merged on
larsoner/circleci-artifacts-redirector-action
, so that we can use the circle URL in other steps. I've temporarily pointed it at my branch.I've also added a few quick-win
role
andaria-label
s to the navs, and done a little bit of looking into some of the things I determined from running local Lighthouse.